Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: [f2py] Add external attribute support. #18181

Merged
merged 1 commit into from
Jan 18, 2021
Merged

ENH: [f2py] Add external attribute support. #18181

merged 1 commit into from
Jan 18, 2021

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Jan 17, 2021

@mattip
Copy link
Member

mattip commented Jan 18, 2021

Now I am paranoid that the tests are not running. Could you point to where this new test is run at least once in CI?

@pearu
Copy link
Contributor Author

pearu commented Jan 18, 2021

See for instance
https://github.com/numpy/numpy/pull/18181/checks?check_run_id=1718020162#step:4:5296

@mattip mattip merged commit 2908338 into numpy:master Jan 18, 2021
@mattip
Copy link
Member

mattip commented Jan 18, 2021

Thanks @pearu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

f2py: external functions declared in single line don't work
2 participants
@pearu @mattip