Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: unify imports in __init__.py #18187

Merged
merged 2 commits into from
Jan 24, 2021
Merged

STY: unify imports in __init__.py #18187

merged 2 commits into from
Jan 24, 2021

Conversation

Amarnath1904
Copy link
Contributor

improve code quality

improve code quality
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless, although the PR title should explain what the change actually is

@Amarnath1904
Copy link
Contributor Author

Seems harmless, although the PR title should explain what the change actually is

hello, actually the PR title explains what the change actually is I didn't make any big changes
all I did is a very small change is _inti.py I think if you will see the code you will get it. :)

@Amarnath1904
Copy link
Contributor Author

actually, this was my first PR so sorry if I don't make sense

@mattip mattip changed the title Update __init__.py STY: unify imports in __init__.py Jan 18, 2021
@mattip mattip added the Priority: low Valid, but not for immediate attention label Jan 18, 2021
numpy/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Charles Harris <charlesr.harris@gmail.com>
@rgommers rgommers merged commit d3653bc into numpy:master Jan 24, 2021
@rgommers
Copy link
Member

Merged, thanks @Amarnath1904.

Please note that we prefer not to get pure style change PRs, because they're on average not worth the churn, review effort and CI time. If you want to try another PR, tackling a bug or documentation issue would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance Priority: low Valid, but not for immediate attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants