MAINT: random shuffle: warn on unrecognized objects, fix empty array bug #18211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
component: numpy.random
03 - Maintenance
09 - Backport-Candidate
eric-wieser
reviewed
Jan 23, 2021
eric-wieser
reviewed
Jan 23, 2021
This would trigger: ``` NotImplementedError: Axis argument is only supported on ndarray objects ``` because empty arrays and array scalars would take the "untyped" path. The bug exists only for Generator, not in RandomState (it doesn't have axis keyword for `shuffle`), but update both because it keeps implementations in sync and the change results in more understandable code also for RandomState.
rgommers
force-pushed
the
fix-shuffle-object
branch
from
251afa9
to
768acb7
Compare
eric-wieser
reviewed
Jan 23, 2021
eric-wieser
reviewed
Jan 23, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
charris
reviewed
Jan 24, 2021
|
Thanks Ralf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-18206, which showed applying
np.random.shuffleon PyTorch tensors gave silently incorrect results.Also found an unrelated bug where shuffling empty array with axis=1 was broken for
Generator.shuffle. This would trigger:because empty arrays would take the "untyped" path.
The bug exists only for
Generator, not forRandomState(it doesn't haveaxiskeyword forshuffle), but update both because it keeps implementations in sync and the change results in more understandable code also forRandomState.