BUG: Use C linkage for random distributions #18264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the numpy.random C API with Cython as described in examples with C++ sources instead of C sources, C++ name mangling will prevent correctly linking to symbols in the
npyrandom
static library which has C linkage. A work-around is described here, but it seems like adding someextern "C"
declarations should do the trick. These are found in nearly all other numpy header files, e.g. npy_math.h.Someone else may need to comment on why
cffi
extending tests are failing, I am unfamiliar withcffi
. EDIT: filtering outextern "C"
statements was enough to get the tests working