Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix missing signed_char dependency. #18350

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Feb 6, 2021

Closes #18335.

@pearu pearu self-assigned this Feb 6, 2021
@charris charris added 06 - Regression 09 - Backport-Candidate PRs tagged should be backported labels Feb 6, 2021
@charris charris added this to the 1.20.1 release milestone Feb 6, 2021
@pearu pearu requested review from charris and mattip February 6, 2021 23:13
@charris
Copy link
Member

charris commented Feb 6, 2021

pearu requested review from charris and mattip

Heh. Pearu, nobody understands how f2py works except yourself :) We may clean things up a bit here and there, fix typos and such, but in the end all we can do is check if it seems reasonable and the tests pass. AFAICT, this looks good.

@charris charris merged commit 8742209 into numpy:master Feb 6, 2021
@charris
Copy link
Member

charris commented Feb 6, 2021

Thanks Pearu.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Feb 6, 2021
@charris charris removed this from the 1.20.1 release milestone Feb 6, 2021
@pearu pearu deleted the pearu/18335 branch February 7, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

f2py (1.20) drops definitiontypedef signed char signed_char; for callbacks in some circumstances
2 participants