BUG: np.in1d bug on the object array (issue 17923) #18369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
reviewed
Feb 8, 2021
|
This is my first contribution to Numpy, could anyone help me with the failing check please? |
|
Thanks @AngelGris . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: np.in1d bug on the object array (closes #17923)
When calling
np.in1d()method with array that contains tuples the comparison didn't work properly due to an underling issue with the unpacking of those tuples. To prevent this, and following the approach suggested by @tylerjereddy I changed the way the comparison is made for arrays of objects, adding a wrapper to those objects preventing tuples from being unpacked.Unit tests for the failing cases mentioned in the issue were also added.