Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix regression in a hidden callback use case in f2py. #18375

Merged
merged 4 commits into from
Feb 9, 2021

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Feb 9, 2021

Closes #18341

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Feb 9, 2021
@pearu pearu changed the title MAINT: Debug issue #18341 [DO NOT MERGE] BUG: fix regression in a hidden callback use case Feb 9, 2021
@pearu pearu marked this pull request as ready for review February 9, 2021 19:45
@pearu pearu requested review from pv and mattip February 9, 2021 19:45
@charris
Copy link
Member

charris commented Feb 9, 2021

I think you need to hit the "ready for review" button.

@@ -92,6 +92,8 @@ def _wrap_method(self, mth, lang, args):
save_compiler = self.compiler
if lang in ['f77', 'f90']:
self.compiler = self.fcompiler
if self.compiler is None:
raise CompileError('%s compiler is not set' % (lang,))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to use f-strings in the future.

@charris charris merged commit 2bdecde into numpy:master Feb 9, 2021
@charris
Copy link
Member

charris commented Feb 9, 2021

Thanks Pearu.

@charris charris changed the title BUG: fix regression in a hidden callback use case BUG: fix regression in a hidden callback use case in f2py. Feb 9, 2021
@charris charris removed 09 - Backport-Candidate PRs tagged should be backported 03 - Maintenance labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

f2py (1.20) causes segmentation fault when calling callback function
2 participants