Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: improve the interface of tofile method #18384

Merged
merged 2 commits into from
Feb 10, 2021
Merged

BUG: improve the interface of tofile method #18384

merged 2 commits into from
Feb 10, 2021

Conversation

szsdk
Copy link
Contributor

@szsdk szsdk commented Feb 10, 2021

Fix #18383

BvB93
BvB93 requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, the only thing that is still missing an actual import of the os module.
Could you put it at the top of the file?

BvB93
BvB93 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattip mattip merged commit 0316d19 into numpy:master Feb 10, 2021
@mattip
Copy link
Member

mattip commented Feb 10, 2021

Thanks @szsdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BvB93 BvB93 BvB93 approved these changes

Assignees
No one assigned
Labels
00 - Bug Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The typing hint for tofile should include Path.
3 participants
@szsdk @mattip @BvB93