MAINT: Added Chain exceptions where appropriate #18400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Mar 13, 2021
numpy/lib/format.py
Outdated
| @@ -595,7 +595,7 @@ def _read_array_header(fp, version): | |||
| d = safe_eval(header) | |||
| except SyntaxError as e: | |||
| msg = "Cannot parse header: {!r}\nException: {!r}" | |||
| raise ValueError(msg.format(header, e)) | |||
| raise ValueError(msg.format(header, e)) from None | |||
There was a problem hiding this comment.
This one should probably be from e
eric-wieser
reviewed
Mar 13, 2021
numpy/lib/format.py
Outdated
| @@ -616,7 +616,7 @@ def _read_array_header(fp, version): | |||
| dtype = descr_to_dtype(d['descr']) | |||
| except TypeError: | |||
| msg = "descr is not a valid dtype descriptor: {!r}" | |||
| raise ValueError(msg.format(d['descr'])) | |||
| raise ValueError(msg.format(d['descr'])) from None | |||
There was a problem hiding this comment.
from e would be better here too
eric-wieser
reviewed
Mar 13, 2021
numpy/ma/mrecords.py
Outdated
| @@ -657,7 +657,7 @@ def openfile(fname): | |||
| try: | |||
| f = open(fname) | |||
| except IOError: | |||
| raise IOError(f"No such file: '{fname}'") | |||
| raise IOError(f"No such file: '{fname}'") from None | |||
There was a problem hiding this comment.
from e again; otherwise if the open fails for permission reasons, all we'll see is "no such file"
abhayaman669
force-pushed
the
chain-exceptions-where-appropriate-1
branch
from
c09c46f
to
0ca74f5
Compare
|
Hi @eric-wieser , I've update the PR. |
eric-wieser
reviewed
Mar 13, 2021
numpy/lib/format.py
Outdated
Comment on lines
597
to
598
| msg = "Cannot parse header: {!r}\nException: {!r}" | ||
| raise ValueError(msg.format(header, e)) | ||
| raise ValueError(msg.format(header, e)) from e |
There was a problem hiding this comment.
I think this one should remove the Exception: {!r} bit, as otherwise the exception appears twice. The one that appears to to from e appears in more detail, so we should remove the other one.
There was a problem hiding this comment.
Okay, I'll remove it and update the PR.
There was a problem hiding this comment.
I've updated PR for this :)
eric-wieser
reviewed
Mar 13, 2021
eric-wieser
reviewed
Mar 13, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
@eric-wieser Ping. |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Thanks @abhayaman669 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #15986
Thank you.