Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove layout overrides for headers #18418

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 15, 2021

Addresses gh-18321.

Also fixes a typo where font-style instead of font-family was used. Since the font boldness and letter-spacing choices were built on top of this mistake, they were removed too.

If someone feels the pydata-sphinx-theme would look nicer with some layout tweaks, I would strongly encourage them to adjust the theme itself upstream.

Before:

image

After:

image

Addresses gh-18321.

Also fixes a typo where `font-style` instead of `font-family` was used. Since the font boldness and letter-spacing choices were built on top of this mistake, they were removed too.

If someone feels the pydata-sphinx-theme would look nicer with some layout tweaks, I would strongly encourage them to adjust the theme itself upstream.
@seberg
Copy link
Member

seberg commented Feb 15, 2021

I don't think you should undo the font-weight, I think it is identical to the numpy.org one. I am not sure about the letter spacing

@eric-wieser
Copy link
Member Author

I can't find a matching font-weight in numpy.org/css/styles.css, but if we pick a matching one that feels very sensible.

Regarding letter spacing, I removed that because the choice varies dramatically with the font, and the old choice was accidentally made with the wrong font.

@seberg
Copy link
Member

seberg commented Feb 15, 2021

href="https://fonts.googleapis.com/css?family=Lato:400,900" I thought the 900 was it, but it was just a guess :). (and that is not the css of course...)

EDIT: This is it probably?:

.hero-title {
    display: flex;
    font-family: 'Lato', sans-serif;
    font-weight: 900;
    font-size: 6em;
    color: #013243;
}

@eric-wieser
Copy link
Member Author

Yeah, that looks like it - but it was 700 not 900 before anyway!

Base automatically changed from master to main March 4, 2021 02:05
@mattip
Copy link
Member

mattip commented Mar 5, 2021

Merging. We can always tweak more if needed, but I think the idea of sticking to defaults is good.

@mattip mattip merged commit 33f9e1f into main Mar 5, 2021
@mattip
Copy link
Member

mattip commented Mar 5, 2021

Thanks @eric-wieser

@eric-wieser
Copy link
Member Author

@bjnath, feel free to create a PR restoring some overrides, especially if they make things consistent with numpy.org

@eric-wieser eric-wieser deleted the eric-wieser/fix-18321 branch September 2, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants