BUG: diagflat could overflow on windows or 32-bit platforms
#18455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Feb 21, 2021
|
Thanks @BvB93 |
charris
changed the title
diagflat could overflow on windows or 32-bit platformsdiagflat could overflow on windows or 32-bit platforms
charris
changed the title
diagflat could overflow on windows or 32-bit platformsdiagflat could overflow on windows or 32-bit platforms
charris
added
component: numpy.lib
and removed
09 - Backport-Candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18449.
For particularly large input arrays the
np.diagflatfunction could yield non-zero diagonal elements due to integer overflow,the latter facilitated by the default
np.arangeinteger-dtype beingnp.int32on windows.This PR fixes aforementioned issue by explicitly setting the dtype to
np.intp.