Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Added documentation for linter (#18423) #18584

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

ganesh-k13
Copy link
Member

Changes:

Added documentation for lint checks as part of #18423

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ganesh-k13. Looks good, just a few small comments.

doc/source/dev/development_environment.rst Outdated Show resolved Hide resolved
doc/source/dev/development_environment.rst Outdated Show resolved Hide resolved
doc/source/dev/development_environment.rst Outdated Show resolved Hide resolved
@ganesh-k13
Copy link
Member Author

Thanks for the review, Ralf. Please let me know if the style guide change is ok.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @ganesh-k13

@rgommers rgommers merged commit 29d8d93 into numpy:main Mar 12, 2021
@rgommers rgommers added this to the 1.21.0 release milestone Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants