MAINT: Do not claim input to binops is self (array object)
#18593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the C-side binops only guarantee that one of the operands is an instance of `PyArrayObject *`, but we do not know which one. Typing the first as `PyArrayObject *` is just misleading for almost no actual payoff
mattip
reviewed
Mar 18, 2021
| @@ -1211,7 +1211,7 @@ PyArray_Conjugate(PyArrayObject *self, PyArrayObject *out) | |||
| n_ops.conjugate); | |||
| } | |||
| else { | |||
| return PyArray_GenericBinaryFunction(self, | |||
| return PyArray_GenericBinaryFunction((PyObject *)self, | |||
There was a problem hiding this comment.
We never test this function with an out argument?
There was a problem hiding this comment.
Strange... I added a small test, this isn't even documented and positional only (that arr.conjugate(out) works).
| .nb_rshift = array_right_shift, | ||
| .nb_and = array_bitwise_and, | ||
| .nb_xor = array_bitwise_xor, | ||
| .nb_or = array_bitwise_or, |
There was a problem hiding this comment.
Was removing the cast here the motivation for this PR?
There was a problem hiding this comment.
This was just a side effect. The reason for this was that I got a bit confused by it when I was trying how to add special handling for Python scalars (for the discussion about making np.array(1, dtype=uint8) + 100 return uint8 no matter the value).
(Since there you have to check for both the first and second argument being a Python scalar)
Co-authored-by: Matti Picus <matti.picus@gmail.com>
This can currently only be passed positionally, and this is undocumented.
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the C-side binops only guarantee that one of the operands
is an instance of
PyArrayObject *, but we do not know whichone. Typing the first as
PyArrayObject *is just misleadingfor almost no actual payoff
I don't care much about this, one if you prefer the old version, happy to just close.