CI: Do not fail CI on lint error #18602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganesh-k13
changed the title
|
Yeah, it seems to work. Thanks, @bashtage for the suggestion. |
ganesh-k13
force-pushed
the
maint_18587_continue_on_lint_error
branch
from
eccadf4
to
87a3925
Compare
seberg
changed the title
|
Thanks Ganesh. I am not sure if there is more to tweak here, but going to put it in for now, since it seems probably better than the hard fails (and is easy to change again). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Sample run showing solution: https://github.com/numpy/numpy/actions/runs/643660439
resolves: #18587
Note: There is one tmp commit to check, I'll remove, if it works