BUG: Use npy_log1p where appropriate in random generation #18634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the number of cases when floating point precision makes the argument to `log` become `0`
bashtage
force-pushed
the
eric-wieser-log1p
branch
3 times, most recently
from
ff4af80
to
826b0e0
Compare
bashtage
changed the title
|
Only coverage failure, which I think is wrong here (but I can't see what codecov is seeing to check due to permissions). |
mattip
approved these changes
Mar 17, 2021
bashtage
force-pushed
the
eric-wieser-log1p
branch
2 times, most recently
from
368eee1
to
e0317e5
Compare
Use log1p(-x) instead of log(1 - x) Seperate legacy version from current closes numpy#17020
bashtage
force-pushed
the
eric-wieser-log1p
branch
from
e0317e5
to
4572e12
Compare
|
Thanks @bashtage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #17020 and preserves legacy generators.
log1pwas left in code where it makes no difference (e.g.,npy_log1pf(-next_double(...))which is always the same aslog(1-next_double(...)) since it seems more consistent.