Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Correct datetime64 missing type overload for datetime.date #18640 #18690

Merged
merged 8 commits into from
Mar 29, 2021
Merged

BUG: Correct datetime64 missing type overload for datetime.date #18640 #18690

merged 8 commits into from
Mar 29, 2021

Conversation

oscar139
Copy link
Contributor

No description provided.

@charris charris changed the title Corrects datetime64 missing type overload for datetime.date #18640 BUG: Correct datetime64 missing type overload for datetime.date #18640 Mar 28, 2021
BvB93
BvB93 reviewed Mar 29, 2021
View reviewed changes
Copy link
Member

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oscar139, I'd say that this PR is in good shape!
I've got two comments about comments, but things should be good to go afterwards.

numpy/__init__.pyi Outdated Show resolved Hide resolved
numpy/__init__.pyi Outdated Show resolved Hide resolved
@BvB93 BvB93 added 09 - Backport-Candidate PRs tagged should be backported Static typing labels Mar 29, 2021
@BvB93 BvB93 linked an issue Mar 29, 2021 that may be closed by this pull request
datetime64 missing type overload for datetime.date #18640
Closed
oscar139 and others added 2 commits March 29, 2021 09:27
@oscar139 @BvB93
Clarify comments on Protocol
84952e2 
Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
@oscar139 @BvB93
Remove unnecessary comments
3eabb1e 
Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
oscar139
oscar139 commented Mar 29, 2021
View reviewed changes
Copy link
Contributor Author

@oscar139 oscar139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed suggestions

BvB93
BvB93 reviewed Mar 29, 2021
View reviewed changes
numpy/__init__.pyi Outdated
class datetime64(generic):
@overload
@overload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@overload
@overload

Style nit: there are some trailing whitespaces here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you kindly for your patience. I will make a greater effort to include matters of style to my contributions.

I used a remove trailing white space tool and it found one after # The datetime64constructors requires an object with the three attributes below,. Did you miss this one or are comments ignored?

BvB93
BvB93 approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charris charris merged commit c8a0966 into numpy:main Mar 29, 2021
@charris
Copy link
Member

charris commented Mar 29, 2021

Thanks @oscar139 .

@BvB93 BvB93 mentioned this pull request Apr 13, 2021
Merged
@BvB93 BvB93 removed the 09 - Backport-Candidate PRs tagged should be backported label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BvB93 BvB93 BvB93 approved these changes

Assignees
No one assigned
Labels
00 - Bug Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datetime64 missing type overload for datetime.date
3 participants
@oscar139 @charris @BvB93