Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Strip extra newline when dumping gfortran version on MacOS #18701

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

kchoudhu
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the 36 - Build Build related PR label Mar 30, 2021
@kchoudhu kchoudhu changed the title BLD: Strip extra newline when dumping gfortran version on MacOS/pkgsrc BLD: Strip extra newline when dumping gfortran version on MacOS Mar 30, 2021
@charris
Copy link
Member

charris commented Mar 31, 2021

For documentation, what problems does the extra newline cause?

@charris charris merged commit 2c9130e into numpy:main Mar 31, 2021
@charris
Copy link
Member

charris commented Mar 31, 2021

Thanks @kchoudhu .

@kchoudhu
Copy link
Contributor Author

Thanks for the merge -- pkgsrc users thank you!

For documentation, what problems does the extra newline cause?

Under certain circumstances on MacOS, gfortran will output two newlines instead of just the one, like so:

"warning: couldn't understand version 11.2\n\n7.5.0"

When this happens, the detected version string is "\n7.5.0", and falls through the version classification code.

strip()-ing the whitespace fixes the problem.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Mar 31, 2021
@charris charris added this to the 1.20.3 release milestone Mar 31, 2021
@charris charris added component: build and removed 09 - Backport-Candidate PRs tagged should be backported labels Apr 13, 2021
@charris charris removed this from the 1.20.3 release milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants