MAINT: Relax the integer-type-constraint of npt._ShapeLike
#18778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was noted in scipy/scipy#13833 (comment) the definition of
npt._ShapeLike
prior to this PR is too strict.The latter currently demands a
builtins.int
(or sequence thereof) while the likes ofnp.integer
or,more generally, objects implementing the
__index__
protocol are generally suitable alternatives.