ENH: Improve the placeholder annotations for the main numpy namespace (part 2) #18780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2021 13:44
Use explicitly defined classes rather than annotating them as `Type[Any]`. The latter currently causes issues with mypy, which does not allow it to be used as a baseclass (because reasons?)
All new function definitions based on the respective functions' docstring
BvB93
commented
Apr 15, 2021
| def concatenate(__a, axis=..., out=..., dtype=..., casting=...): ... | ||
| def copyto(dst, src, casting=..., where=...): ... | ||
| def datetime_as_string(arr, unit=..., timezone=..., casting=...): ... | ||
| def datetime_data(__dtype): ... |
|
Thanks Bas. |
This was referenced Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #18765.
This PR makes two new sets of improvements to the placeholder annotations:
Type[Any]annotations of the classes with explicit class definitions. The former can cause issues as mypy does not allow one to inherit from such objects (e.g. MAINT: Add inline type hintings for stats.qmc scipy/scipy#13833 (comment)).Callable[..., Any]annotation of the C-based functions with explicit function definitions. The relevant signatures were herein adapted from the functions' docstring.