-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH, SIMD: Add support for dispatching C++ sources #18837
Conversation
seiko2plus
commented
Apr 22, 2021
Same usage as the C dispatch-able sources except files extensions should be `.dispatcher.cpp` or `.dispatch.cxx` rather than `.dispatch.c`
8c3daaf
to
2d9e75f
Compare
Wouldn't meson be more of a mid- to longerterm solution/replacement, while we would like to try function templates fairly soon? And I guess most of distutils does all of this already and this is just generalizes the same things to the simd dispatching? So, I know neither this code well nor the C++ deployment in general, but it seems fine to just go with it. |
Exactly, SciPy has lots of C++ code and happily uses |
@seiko2plus this PR looks good, but since there's no C++ code yet it's hard to test. I'm not suggesting you add in C++ code here (that would make it large and hard to merge). But did you test it locally? Is there a branch or WIP PR you could share to test this? Or would you prefer to just merge this and iterate on it if it later turns out to be incomplete? |
Sure, I did.
The current work is kinda a miss a little bit and I'm working on splitting them into 4 PRs:
Yes, that what I prefer but I can add a testing unit for C++ dispatching if it's nesseary. What do you think? |
Let's wait until the rest gets in and is working. I'm not sure what we should be testing at this point. Thanks Sayed. |
That seems fine, it looks like Breathe is pretty actively maintained right now. The related Exhale (https://github.com/svenevs/exhale) is best avoided, it's unmaintained. |