DOC: Add Gitpod development documentation #18839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
melissawm
reviewed
Apr 25, 2021
There was a problem hiding this comment.
Thank you for this @trallard ! I left a few comments, some are very optional. I wonder if there´s a way to make the images a bit larger - the fonts on some of them are too small for me to make out the text and I think they add a lot of value to the docs. Otherwise, I think this is in the right place and is very well written!
|
I can zoom everything in and get new images done. Should only take a couple of minutes. |
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
charris
reviewed
Apr 26, 2021
|
The text would be much nicer to read if you kept the lines < 80 characters. I suspect your editor is wrapping rather than breaking lines. |
|
Thanks for the review @charris and @melissawm! Made some changes including replacing the images. Let me know what you think |
|
Thanks Tania. |
|
Happy to help. |
verma16Ayush
pushed a commit
to verma16Ayush/numpy
that referenced
this pull request
Apr 30, 2021
DOC: Add Gitpod development documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
Additional notes:
This is complementary to PR #18822
@melissawm I tried to find a good place for this docs but will defer to your best judgement (I also added to the TOC in
dev/index.rst)