Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add favicon #18841

Merged
merged 2 commits into from
Apr 23, 2021
Merged

DOC: Add favicon #18841

merged 2 commits into from
Apr 23, 2021

Conversation

trallard
Copy link
Contributor

While working on the gitpod implementation I noticed there was no favicon in the docs. Which as someone who always has way too many tabs open was rather annoying.

Overview_—_NumPy_v1_20_Manual

This PR adds the basic favicon and the .png files for various sizes too.

Since the pydata-sphinx-theme is currently pinned at 5.x or so I cannot add the config for the multiple favicons so that can be done after the issues with build times in 6.0.2 are fixed

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks @trallard!

@rgommers rgommers merged commit 2946a21 into numpy:main Apr 23, 2021
@trallard trallard deleted the trallard/patch-docs branch April 27, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants