ENH: Improve the placeholder annotations within sub-modules #18842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 23, 2021 13:56
BvB93
changed the title
BvB93
commented
Apr 23, 2021
Comment on lines
+106
to
+107
| def _assert_valid_refcount(op): ... | ||
| def _gen_alignment_data(dtype=..., type=..., max_size=...): ... |
There was a problem hiding this comment.
There are currently two private (?) functions included within np.testing.__all__,
anyone know what's up with that?
There was a problem hiding this comment.
They seem to have been there for a long time, they track back to 2009 and 2013 and are used outside the testing package. My guess is that it is an accident of naming. It would be interesting if pytest had something equivalent.
|
Thanks Bas. |
BvB93
pushed a commit
to BvB93/numpy
that referenced
this pull request
May 5, 2021
Adds placeholders for two `np.testing` objects previously missed in numpy#18842.
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xref #18838.
This PR improves the current
Any-based placeholder annotations within a number of modules,replacing them with explicit functions, classes or objects when appropiate. While parameters of the
respective methods and functions remain unannotated (for now), these changes nevertheless provides
a notable improvement over a plain
Any.Part 1 in a series of 2 or 3 PRs.