DOC: Move Sphinx numpy target in reference index. #18845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
changed the title
|
This LGTM - I´m pretty sure the overlap you´re describing is related to #18620, can you confirm? |
|
Ah, yes, sorry - the overlap comment is a duplicate of #18620! |
|
And for completeness: I do think it's still worth moving the target location. Following the suggestion in #18620 to try with /devdocs/ instead of /stable/, the navbar issue is fixed but the target location still goes too far down in the page (IMO): https://numpy.org/devdocs/reference/index.html#module-numpy goes to: With this PR, it should go to: |
|
Agreed - thanks @adrn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible improvement / step in the direction of a fix for #18844. However, this won't be a complete fix for that issue because the nav bar will still overlap the target location that is scrolled to in the body text.