MAINT: Fix the typo "implment" #18856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
reviewed
Apr 27, 2021
| @@ -1955,7 +1955,7 @@ PyArray_AddCastingImplementation_FromSpec(PyArrayMethod_Spec *spec, int private) | |||
| if (meth == NULL) { | |||
| return -1; | |||
| } | |||
| int res = PyArray_AddCastingImplmentation(meth); | |||
| int res = PyArray_AddCastingimpelmentation(meth); | |||
There was a problem hiding this comment.
You shouldn't change the capitalization of this
bashtage
reviewed
Apr 27, 2021
| @@ -57,7 +57,7 @@ PyArray_FindConcatenationDescriptor( | |||
| npy_intp n, PyArrayObject **arrays, PyObject *requested_dtype); | |||
|
|
|||
| NPY_NO_EXPORT int | |||
| PyArray_AddCastingImplmentation(PyBoundArrayMethodObject *meth); | |||
| PyArray_AddCastingimpelmentation(PyBoundArrayMethodObject *meth); | |||
There was a problem hiding this comment.
Same here. You can fix spellign w/o changing the capitalization.
There was a problem hiding this comment.
It is still misspelled, should be "Implementation".
There was a problem hiding this comment.
done. Thank you for reviewing
charris
approved these changes
Apr 27, 2021
|
Thanks @howjmay . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo
implmentshould beimplement.