ENH: Add min values comparison for floating point #18882
Conversation
howjmay
changed the title
seiko2plus
added
the
component: SIMD
|
close/open to re-run travis-ci. |
|
This seems to be a follow-on PR to adding max value comparison. Which PR was that? |
|
ahh, #18863 |
| @@ -390,6 +390,8 @@ SIMD_IMPL_INTRIN_1(@intrin@_@sfx@, v@sfx@, v@sfx@) | |||
| #if @fp_only@ | |||
| SIMD_IMPL_INTRIN_2(max_@sfx@, v@sfx@, v@sfx@, v@sfx@) | |||
| SIMD_IMPL_INTRIN_2(maxp_@sfx@, v@sfx@, v@sfx@, v@sfx@) | |||
| SIMD_IMPL_INTRIN_2(min_@sfx@, v@sfx@, v@sfx@, v@sfx@) | |||
| SIMD_IMPL_INTRIN_2(minp_@sfx@, v@sfx@, v@sfx@, v@sfx@) | |||
There was a problem hiding this comment.
style nit: just above there is a repeat clause for 4 values, here all 4 are spelled out explicitly. Can we unify the approach?
There was a problem hiding this comment.
There was a problem hiding this comment.
So let me refactor to this way
|
I understand correctly that these two PRs only add the intrinsic, there will be a follow-on one to use it? |
|
|
howjmay
force-pushed
the
simd-min
branch
4 times, most recently
from
9a97e80
to
a70e5eb
Compare
Add the similar implementation for minimum value comparison.
|
Thanks @howjmay |
|
Thank you @mattip and @seiko2plus |
|
@howjmay, |
| """ | ||
| Test intrinics: | ||
| npyv_max_##SFX | ||
| npyv_maxp_##SFX | ||
| """ |
There was a problem hiding this comment.
I didn't see these changes during my latest review.
There was a problem hiding this comment.
Sorry for removing this accidentally
I will fix this in the following PR of maximum and minimum
| @@ -346,6 +341,31 @@ def test_max(self): | |||
| _max = self.max(vdata_a, vdata_b) | |||
| assert _max == data_max | |||
|
|
|||
| def test_min(self): | |||
There was a problem hiding this comment.
the following are missing too
"""
Test intrinics:
npyv_min_##SFX
npyv_minp_##SFX
"""I think these changes made during your latest push
Add the similar implementation for minimum value comparison.