ENH: Add SIMD operations for min and max value comparision #18889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
force-pushed
the
simd-min-max-integer
branch
from
ebbc5d0
to
71644f0
Compare
howjmay
force-pushed
the
simd-min-max-integer
branch
12 times, most recently
from
0f0bbf9
to
b3ea1c0
Compare
howjmay
force-pushed
the
simd-min-max-integer
branch
from
b3ea1c0
to
111f35d
Compare
seiko2plus
added
the
component: SIMD
|
@howjmay, Could you please add a testing case for integer min/max? |
howjmay
force-pushed
the
simd-min-max-integer
branch
from
111f35d
to
da0bb26
Compare
|
@seiko2plus Is there anything I should fix or add? |
seiko2plus
requested changes
May 6, 2021
There was a problem hiding this comment.
The current testing case only tests f32/f64, you have to add a new test case for integer max/min at the tail of the following class
numpy/numpy/core/tests/test_simd.py
Lines 158 to 161 in c753b23
howjmay
force-pushed
the
simd-min-max-integer
branch
3 times, most recently
from
22b1331
to
d8ae6e0
Compare
howjmay
force-pushed
the
simd-min-max-integer
branch
from
d8ae6e0
to
2618ff5
Compare
howjmay
force-pushed
the
simd-min-max-integer
branch
from
2618ff5
to
e755377
Compare
Thank you so much for helping |
|
Thanks @howjmay . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SIMD operations for comparing maximum and minimum values.
npyv_[max|min]_u64is not implemented in this PR, since AVX2 has some problems on implementing them.