MAINT: Adjust NumPy float hashing to Python's slightly changed hash #18908
Conversation
seberg
changed the title
seberg
changed the title
seberg
force-pushed
the
fix-float-hash
branch
2 times, most recently
from
bf4a1a7
to
6194e3e
Compare
|
OK, I did compile against dev python (which includes the patch) and it works. (I did not run the test suit) |
| } | ||
|
|
||
| /* borrowed from complex_hash */ | ||
| static npy_hash_t | ||
| c@lname@_arrtype_hash(PyObject *obj) | ||
| { | ||
| npy_hash_t hashreal, hashimag, combined; | ||
| hashreal = _Py_HashDouble((double) | ||
| PyArrayScalar_VAL(obj, C@name@).real); | ||
| hashreal = Npy_HashDouble(obj, (double)PyArrayScalar_VAL(obj, C@name@).real); |
There was a problem hiding this comment.
yeah, how strict are we about the 79 chars? Lately, I have started to not worry if it I figure the meaning is clear even if you don't see the last few chars.
Happy to change though.
There was a problem hiding this comment.
We aren't limited by the terminal these days, so we could probably increase the line length as long as readability is good, say 85 characters. Might be worth discussing, especially with C++ in the future, C++ tends to long lines.
| @@ -3159,7 +3159,7 @@ static npy_hash_t | |||
| return y; | |||
| } | |||
| #endif | |||
| /**end repeat**/ | |||
| /**end repeat**/y | |||
There was a problem hiding this comment.
Probably disappears when the file is generated, so no error.
|
Nitpicks: Couple of long lines in C code. |
This is necessary, since we use the Python double hash and the semi-private function to calculate it in Python has a new signature to return the identity-hash when the value is NaN. closes numpygh-18833, numpygh-18907
|
Thanks Sebastian. |
This is necessary, since we use the Python double hash and the
semi-private function to calculate it in Python has a new signature
to return the identity-hash when the value is NaN.
closes gh-18833, gh-18907
It seems we had no tests at all, so I added some. I honestly did not test this on 3.10b1, since I did not yet bother to get a Py 3.10 version running locally.