Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update beginners docu for sum function with axis #18954

Merged
merged 1 commit into from
May 9, 2021

Conversation

EvaJau
Copy link
Contributor

@EvaJau EvaJau commented May 9, 2021

Hopefully clarifies how summing over an axis is done. Fixes #16697

Hopefully clarifies how summing over an axis is done. Issue numpy#16697
@melissawm
Copy link
Member

Hi @EvaJau - you can edit your description to say either "Closes #16697", "Fixes #16697" or any of the other magic words listed here: https://docs.github.com/pt/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@EvaJau
Copy link
Contributor Author

EvaJau commented May 9, 2021

Hi @EvaJau - you can edit your description to say either "Closes #16697", "Fixes #16697" or any of the other magic words listed here: https://docs.github.com/pt/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Yes, sure. Thanks for the hint!

@melissawm
Copy link
Member

Hi @EvaJau just in case you were pairing up with someone to work on this, do you want to add them as co-author to your commit message?

@EvaJau
Copy link
Contributor Author

EvaJau commented May 9, 2021

Hi @EvaJau just in case you were pairing up with someone to work on this, do you want to add them as co-author to your commit message?

Hey, I didn't pair for this issue but thanks for asking!

@melissawm
Copy link
Member

This looks good to me, although I'm not a native English speaker it does look clearer. Thanks!

@melissawm melissawm merged commit e1e3614 into numpy:main May 9, 2021
@EvaJau EvaJau deleted the doc-sum-beginners branch May 9, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Update Sum function with axis
2 participants