-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Improve datetime64 docs. #18957
Conversation
update from main - fixing SVD
Hello, @katleszek , can you add to the PR description a note about which issue this will close? You can check this page for more info on how to do this: https://docs.github.com/pt/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
Thanks @katleszek! The issue also talks about the "experimental" note on https://numpy.org/devdocs/reference/arrays.datetime.html that should be removed: We can safely get rid of that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @katleszek. The example is good, I suggest a couple of textual changes.
Adding clarification to datetime64. Resolves #14299 |
The refguide checker on Azure is unhappy:
You can reproduce this failure locally by running |
Thanks for the advice! Fixed the Azure unhappiness, but get a smoke_test fail - how can I check what is wrong with this one? |
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Thanks @katleszek |
@@ -218,10 +218,15 @@ def add_newdoc_for_scalar_type(obj, fixed_aliases, doc): | |||
|
|||
add_newdoc_for_scalar_type('datetime64', [], | |||
""" | |||
A datetime stored as a 64-bit integer, counting from ``1970-01-01T00:00:00``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it make sense to keep this description too? This change seems to remove information about datetime64
and add information about datetime64.__new__
. Ideally we'd have both!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
Adding clarification to datetime64. Resolves #14299