BUG: Fix duplicate variable names in compiler check for AVX512_SKX #19048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that checks for AVX512 SKX intrisics compiler support has a bug which always causes the check to fail and hence disables code that used AVX512_SKX features. Introduced in numpy#16871.
mattip
reviewed
May 20, 2021
numpy/core/setup_common.py
Outdated
Comment on lines
197
to
198
| __m512i unused_temp = _mm512_castps_si512(_mm512_set1_ps(1.0));\ | ||
| _mm_mask_storeu_epi8(NULL, 0xFF, _mm_broadcastmb_epi64(temp))', |
There was a problem hiding this comment.
Which temp is meant to be used in line 198?
There was a problem hiding this comment.
The one on line 196, it is using the correct input. I added an extra line of code in #16871 that used the same variable name which ended up disabling AVX512_SKX.
mattip
approved these changes
May 20, 2021
|
Not sure what happened here: https://travis-ci.com/github/numpy/numpy/jobs/506643936 |
|
We have been seeing that failure itermittently over the last few days. Since it is not relevant for this PR, merging. Thanks @r-devulap |
rgommers
added
the
component: SIMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that checks for AVX512 SKX intrisics compiler support has a bug which always causes the check to fail and hence disables code that used AVX512_SKX features. Introduced in #16871.