ENH: Add annotations for np.pad
#19223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
commented
Jun 11, 2021
Comment on lines
+85
to
+86
| mode: _ModeFunc, | ||
| **kwargs: Any, |
There was a problem hiding this comment.
Whichever **kwargs are valid depends on the passed callback in question.
Comment on lines
+55
to
+56
| # TODO: In practice each keyword argument is exclusive to one or more | ||
| # specific modes. Consider adding more overloads to express this in the future. |
There was a problem hiding this comment.
Personally I didn't feel it was worthwhile to add 3 * 2 additional overloads for linking specific keyword arguments to mode values.
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the title: this PR adds annotations for the
np.padfunction, including some basic dtype support.