ENH: Support major version larger than 9 in NumpyVersion #19240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19214.
This PR fixes
numpy.lib.NumpyVersionto be able to parse major versions larger than 9, as the docstring says:Currently minor and bugfix version supports > 9 but major is not.
Motivation: I'm maintaining CuPy, and we are expecting the next major release to be v10.x. I understand this enhancement is not necessary for NumPy for the foreseeable future, but it would be great if CuPy's version strings (which follows the NumPy's convention) can be parsed as well.