BUG: Fix cast safety and comparisons for zero sized voids #19322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are more complicated and weird things could happen... right now, the only "weird" thing is that some sized to unsized voids casts may be considered as safe when they should not be. I think this is fine... In general, we need to fix all casts to a strict interpretation of V0, S0, and U0 and then then allow "V", "S", and "U" explicitly on the python entry-points Right now, this is as minimal as I could make it work, it isn't as minimal as I would _like_ after a release, but here we go...
seberg
commented
Jun 24, 2021
| @@ -147,6 +147,9 @@ def test_to_void(self): | |||
| assert not np.can_cast("U1", "V1") | |||
| # Structured to unstructured is just like any other: | |||
| assert np.can_cast("d,i", "V", casting="same_kind") | |||
| # Unstructured void to unstructured is actually no cast at all: | |||
| assert np.can_cast("V3", "V", casting="no") | |||
| assert np.can_cast("V0", "V", casting="no") | |||
There was a problem hiding this comment.
If this is confusing, it is because V is interpreted as the unsized void (or void DType) and not V0 here. You can't use an actual V0 here, but if you could the result would be same-kind.
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are more complicated and weird things could happen...
right now, the only "weird" thing is that some sized to unsized
voids casts may be considered as safe when they should not be.
I think this is fine... In general, we need to fix all casts
to a strict interpretation of V0, S0, and U0 and then then
allow "V", "S", and "U" explicitly on the python entry-points
Right now, this is as minimal as I could make it work, it isn't
as minimal as I would like after a release, but here we go...
Closes gh-19305