Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add annotations for np.core.getlimits #19421

Merged
merged 3 commits into from
Jul 19, 2021
Merged

ENH: Add annotations for np.core.getlimits #19421

merged 3 commits into from
Jul 19, 2021

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Jul 6, 2021

This PR adds annotations for all classes in np.core.getlimits, most notably finfo and iinfo.

The module in question also contains the private MachArLike class. While I'd love to skip it in its entirety,
MachArLike instances are exposed via the public finfo.machar attribute.

@charris charris merged commit 45cfd11 into numpy:main Jul 19, 2021
@charris
Copy link
Member

charris commented Jul 19, 2021

Thanks Bas.

@BvB93 BvB93 deleted the getlimits branch July 19, 2021 20:36
@BvB93 BvB93 mentioned this pull request Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BvB93 @charris