Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Codespell for NumPy CI #19594

Closed
wants to merge 5 commits into from

Conversation

ganesh-k13
Copy link
Member

@ganesh-k13 ganesh-k13 commented Aug 2, 2021

Codespell CI

  1. Added a new argument to linter.py to run codespell
  2. Added the new tool to pipelines

Usage

# We have misspelled processor with processer:
$ python3 tools/linter.py --codespell --uncommitted
7: +take advantage of specialized processer functionality are preferred. Examples
        processer ==> processor
10: +are multithreaded and processer dependent, environmental variables and external
        processer ==> processor
13: +or specify the processer architecture.
        processer ==> processor

-------8<-------
SUMMARY:
processer     3

TODO

  • Add runtest.py flags
  • Add usage docs

Note:

Adding a tmp commit 92a9826 to test the CI

resolves: #13694
cc: @luzpaz

@github-actions github-actions bot added the 36 - Build Build related PR label Aug 2, 2021
@bsipocz
Copy link
Member

bsipocz commented Sep 7, 2022

This is now conflicting, so will need a rebase, or a complete restart in a new PR (thus I'm adding the close label, it's for the PR not for the idea).

@bsipocz bsipocz added the 57 - Close? Issues which may be closable unless discussion continued label Sep 7, 2022
@ganesh-k13
Copy link
Member Author

I'll close this, for now, let's see if it's worth adding in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR 57 - Close? Issues which may be closable unless discussion continued
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: use codespell, flake8 to check code before merging?
2 participants