ENH: Add annotations for np.lib.npyio
#19667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
commented
Aug 13, 2021
BvB93
commented
Aug 13, 2021
Comment on lines
+183
to
+185
| @overload | ||
| def fromregex( | ||
| file: str | IO[Any], |
There was a problem hiding this comment.
fromregex is currently the only file-manipulation-function that does not support os.PathLike implementations.
Might be something to add in a future PR?
There was a problem hiding this comment.
Maybe open an issue so it doesn't get lost.
There was a problem hiding this comment.
Good call, I just created one at #19679.
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds annotations for the various functions in
np.lib.npyio.