-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Check whether the datatype is of Datetime before typecasting as usual. #19722
Conversation
Please add a test that fails before, passes after the change. |
Reproducing code example: Now after code changes the typecasting would not be possible and the np.allclose(a,a) would run for even dtype = 'datetime64[ns]' |
I asked only that you revert the changes to |
Sorry for such immature execution of my task. I am totally new to this environment. Hope to learn and seeking guidance from you all. |
I think you might want to back out all the changesets other than abe9ff0 and then add the test in a second changeset. Your PR should only consist of
|
I am going to close this. The fix is likely right, but its a mess unfortunately and old. It also needs a rebase anyway, creating a new PR from scratch seems just as well (which anyone is very welcome to do!). |
Closes #19267, np.allclose fails with dtype datetime64
This is my first contribution, Seeking guidance and support from such huge community.