ENH: Add annotations for np.memmap
#19979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
commented
Sep 27, 2021
Comment on lines
+640
to
+649
| # NOTE: `seek`, `write` and `flush` are technically only required | ||
| # for `readwrite`/`write` modes | ||
| class _MemMapIOProtocol(Protocol): | ||
| def flush(self) -> object: ... | ||
| def fileno(self) -> SupportsIndex: ... | ||
| def tell(self) -> int: ... | ||
| def seek(self, offset: int, whence: int, /) -> object: ... | ||
| def write(self, s: bytes, /) -> object: ... | ||
| @property | ||
| def read(self) -> object: ... |
There was a problem hiding this comment.
Interestingly memmap.__new__ uses the read attribute for identifying file-like objects, but then never actually calls it.
Comment on lines
+1
to
+5
| from typing import List | ||
|
|
||
| from numpy import memmap as memmap | ||
|
|
||
| __all__: List[str] |
There was a problem hiding this comment.
It's not strictly necessary to add stub file here, but it does make it easier to find the memmap annotations if someone is looking for them.
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds annotations for the
np.memmapclass.