BUG: ma.testutils.assert_equal throws AssertionError on np.nan #20017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charris would you mind reviewing this? Thanks! |
|
Waiting for this to be merged |
mattip
reviewed
Dec 16, 2021
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| run_module_suite() |
There was a problem hiding this comment.
Does this replace existing tests, if so please remove them from the previous locations.
mattip
reviewed
Dec 16, 2021
| @@ -108,7 +108,7 @@ def assert_equal_records(a, b): | |||
| def assert_equal(actual, desired, err_msg=''): | |||
| """ | |||
| Asserts that two items are equal. | |||
|
|
|||
There was a problem hiding this comment.
Revert this change
Suggested change
mattip
reviewed
Dec 16, 2021
| @@ -126,7 +126,8 @@ def assert_equal(actual, desired, err_msg=''): | |||
| if not (isinstance(actual, ndarray) or isinstance(desired, ndarray)): | |||
| msg = build_err_msg([actual, desired], err_msg,) | |||
| if not desired == actual: | |||
| raise AssertionError(msg) | |||
| # Handle case using testing.assert_equal | |||
| return np.testing.assert_equal(actual, desired) | |||
There was a problem hiding this comment.
This doesn't seem right. Why build the error message and do the check, only to defer to the base-class check? Also: What happens if the order of the arguments is reversed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6661, #20022.
np.ma.testutils.assert_equalnow defaults tonp.testing.assert_equalif actual or desired are not maskedPreviously
After Fix