ENH: Add annotations for np.lib.function_base part 3/3
#20036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BvB93
commented
Oct 5, 2021
Comment on lines
+632
to
+634
| # NOTE: Not an alias, but they do have identical signatures | ||
| # (that we can reuse) | ||
| quantile = percentile |
There was a problem hiding this comment.
A little bit of background:
Mypy defines functions exclusively according to their signatures,
so two functions with identical signatures are, as far as mypy is concerned, equivalent.
|
Thanks Bas. Note the percentile, quantile, and the nan versions are about to add a bunch new methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #20034
The last PR in a series for adding
np.lib.function_baseannotations.Adds annotations for the following functions:
add_newdoc_ufuncquantilepercentiletrapzmeshgriddeleteinsertappenddigitize