ENH: Add annotations for np.matrix
#20105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Oct 12, 2021
| def mean(self, axis: None | _ShapeLike = ..., dtype: DTypeLike = ..., out: _NdArraySubClass = ...) -> _NdArraySubClass: ... | ||
|
|
||
| @overload | ||
| def std(self, axis: None = ..., dtype: DTypeLike = ..., out: None = ..., ddof: float = ...) -> Any: ... |
There was a problem hiding this comment.
Do int count as float for ddof?
There was a problem hiding this comment.
I see that it works, but it is documented as an int. Maybe that should be changed?
There was a problem hiding this comment.
Yes, int is considered a subtype of float per PEP 484.
There was a problem hiding this comment.
I see that it works, but it is documented as an int. Maybe that should be changed?
There seems to be a pre-existing issue that proposes this change (#18650); based on this I think it might be worthwhile.
There was a problem hiding this comment.
It works for floats like 1.5, and, IIRC, that can sometimes be useful. So probably the documentation should be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic annotations for
np.matrix.At this point we've hit to bottom of the barrel as far as annotating the main numpy namespace is concerned.
After this PR only
chararrayandMachArremain.