Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG, SIMD: Workaround broadcasting SIMD 64-bit integers on MSVC 32-bit #20219

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

seiko2plus
Copy link
Member

Avoid using any of intrinsics that related to broadcasting 64-bit integers
with MSVC 32-bit, even if they are apparently work on newer versions.
They had bad impact on the generated instructions, sometimes the
compiler deal with them without the respect of 32-bit mode which
lead to crush due to execute 64-bit instructions and other times
generate bad emulated instructions.

closes #20216

@seiko2plus seiko2plus added 00 - Bug 09 - Backport-Candidate PRs tagged should be backported component: SIMD Issues in SIMD (fast instruction sets) code or machinery labels Oct 28, 2021
@charris charris merged commit 28173db into numpy:main Oct 28, 2021
@charris
Copy link
Member

charris commented Oct 28, 2021

Let's give this a shot. Thanks Sayed.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 3, 2021
@seiko2plus seiko2plus deleted the simd_msvc_broadcast_64bit branch November 5, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00 - Bug component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Integer divide tests fail on 32 bit Windows wheel builds.
2 participants