Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: remove code for supporting GCC <4 in Mingw32CCompiler #20333

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

lazka
Copy link
Contributor

@lazka lazka commented Nov 9, 2021

The last GCC 3.x release before 4.0 was 3.4 which was released 2004,
so 17 years ago.

Removes all code only used with those old toolchains.

This is an alternative to #20330

The last GCC 3.x release before 4.0 was 3.4 which was released 2004,
so 17 years ago.

Removes all code only used with those old toolchains.
@lazka lazka force-pushed the mingw-remove-old-version-checks branch from 207c322 to 7e03a56 Compare November 9, 2021 18:44
Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes

@FFY00
Copy link
Contributor

FFY00 commented Nov 9, 2021

If this gets merged, we can go ahead and merge pypa/distutils#62.

@mattip
Copy link
Member

mattip commented Nov 9, 2021

What kind of backward compatibility promise does pypa/distutils (which I assume is merged frequently into pypa/setuptools)? Won't pypa/distutils#62 break every user of a NumPy older than this PR?

@FFY00
Copy link
Contributor

FFY00 commented Nov 9, 2021

I am not entirely sure about the backwards compatibility promises, but it shouldn't break unless you are using an old GCC version. I think that's reasonable. We can defer the decision to @jaraco, who should have a better handle on this.

@lazka
Copy link
Contributor Author

lazka commented Nov 9, 2021

What kind of backward compatibility promise does pypa/distutils (which I assume is merged frequently into pypa/setuptools)? Won't pypa/distutils#62 break every user of a NumPy older than this PR?

Are you talking about my proposal in pypa/distutils#62 (comment) ? The linked PR shouldn't change anything (and not sure if it is correct tbh...).

As for pypa/distutils, it's synced into setuptools, but not used unless SETUPTOOLS_USE_DISTUTILS is set, so its scope is very limited at this point. The MSYS2 project maintains a mingw-w64 fork of CPython and we have started to sync in pypa/distutils since CPython closed all distutils bug reports and is no longer accepting changes in that area, so it has some usage in MSYS2.

(I'm not aware of any other project besides MSYS2 building numpy with mingw-w64 though and we require quite a few patches to make it work, some are clang related though. )

@mattip mattip merged commit e1239e7 into numpy:main Nov 9, 2021
@mattip
Copy link
Member

mattip commented Nov 9, 2021

Thanks for the cleanup @lazka

@lazka
Copy link
Contributor Author

lazka commented Nov 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants