-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: remove code for supporting GCC <4 in Mingw32CCompiler #20333
Conversation
The last GCC 3.x release before 4.0 was 3.4 which was released 2004, so 17 years ago. Removes all code only used with those old toolchains.
207c322
to
7e03a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming CI passes
If this gets merged, we can go ahead and merge pypa/distutils#62. |
What kind of backward compatibility promise does pypa/distutils (which I assume is merged frequently into pypa/setuptools)? Won't pypa/distutils#62 break every user of a NumPy older than this PR? |
I am not entirely sure about the backwards compatibility promises, but it shouldn't break unless you are using an old GCC version. I think that's reasonable. We can defer the decision to @jaraco, who should have a better handle on this. |
Are you talking about my proposal in pypa/distutils#62 (comment) ? The linked PR shouldn't change anything (and not sure if it is correct tbh...). As for pypa/distutils, it's synced into setuptools, but not used unless (I'm not aware of any other project besides MSYS2 building numpy with mingw-w64 though and we require quite a few patches to make it work, some are clang related though. ) |
Thanks for the cleanup @lazka |
Thanks! |
The last GCC 3.x release before 4.0 was 3.4 which was released 2004,
so 17 years ago.
Removes all code only used with those old toolchains.
This is an alternative to #20330