BUG: numpy.ma mask nan on __itruediv__ #20551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug showed up because __itruediv__ differed from __truediv__ (which does mask the NaN). Unfortunately, both methods use different strategies to protect against division by 0, which leads to inconsistencies (that one in particular).
bsipocz
added
the
triage review
seberg
removed
the
triage review
|
Removing the triage-review for now again. It would be nice to make a decision though (see also the linked other issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20506, see my comment there for details about the issue.
This is pretty old code, i tried to match the style.