MAINT: Help boost::python libraries at least not crash #20616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an almost random "sanity check" to `PyArray_EquivTypes` for the sole purpose of allowing boost::python compiled libs to _not crash_. boost::python is buggy, it needs to be fixed. This may break them (I am unsure), because some conversions which used to work may fail here (if they worked, they only worked because random type data may have matched up correctly for our scalar types). We could error, or warn or... but I hope boost::python will just fix this soon enough and future us can just delete the whole branch. Replaces numpygh-20507
|
If we do this and if there will be another 1.21.x, we should also backport it to 1.21.x. |
seberg
commented
Dec 17, 2021
| * | ||
| * boost::python has/had a bug effectively using EquivTypes with | ||
| * `type(arbitrary_obj)`. That is clearly wrong as that cannot be a | ||
| * `PyArray_Descr *`. We assume that `type(type(type(arbitrary_obj))` |
There was a problem hiding this comment.
Yes, type(type(type(obj))) should be right for the sanity check :).
|
Thanks Sebastian, seems harmless enough, but I'm not particularly happy about working around what looks like a boost bug. Let's not backport anymore stuff if we can help it, it's starting to look like 1.22.1 and we haven't even made it to rc3 yet :) |
charris
added
component: numpy._core
and removed
09 - Backport-Candidate
|
Sounds fair, I am in no rush to backport (the boost users should also validate it quickly to be frank) and it would be nicer if boost::python just fixes things and we revert... |
|
@seberg Thanks for doing this. I can confirm this commit resolves the segfaults in boostorg/python#376 and cctbx/cctbx_project#627. |
dwpaley
added a commit
to cctbx/cctbx_project
that referenced
this pull request
Jan 4, 2022
This reflects the resolution of #627 as discussed in several other issues and PRs: - boostorg/python#376 - numpy/numpy#20507 - numpy/numpy#20616 Leaving this "bibliography" here because the fix in numpy PR 20616 is considered temporary; thus someday we may have to revisit this to fix the underlying bug in boost::python. Co-authored-by: Billy Poon <bkpoon@lbl.gov>
dwpaley
added a commit
to cctbx/cctbx_project
that referenced
this pull request
Jan 5, 2022
This reflects the resolution of #627 as discussed in several other issues and PRs: - boostorg/python#376 - numpy/numpy#20507 - numpy/numpy#20616 Leaving this "bibliography" here because the fix in numpy PR 20616 is considered temporary; thus someday we may have to revisit this to fix the underlying bug in boost::python. Co-authored-by: Billy Poon <bkpoon@lbl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an almost random "sanity check" to
PyArray_EquivTypesfor the sole purpose of allowing boost::python compiled libs to
not crash.
boost::python is buggy, it needs to be fixed. This may break them
(I am unsure), because some conversions which used to work may fail
here (if they worked, they only worked because random type data may
have matched up correctly for our scalar types).
We could error, or warn or... but I hope boost::python will just fix
this soon enough and future us can just delete the whole branch.
Replaces gh-20507