ENH: add hook and test for PyInstaller. #20745
Merged
+115
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoodsend
force-pushed
the
pyinstaller-hook
branch
from
efbe4af
to
a7d8d8b
Compare
rgommers
reviewed
Jan 7, 2022
bwoodsend
force-pushed
the
pyinstaller-hook
branch
3 times, most recently
from
b8acf2a
to
252ea91
Compare
|
The two travis failures will disappear when PyInstaller next releases (which was supposed to be this morning) shipping pre-compiled wheels for those architectures. Something unpleasant appears to have knocked out installing cygwin. Hopefully egor-tensin/setup-cygwin will mop it up quickly. What's wrong with Windows 32bit on Azure is a mystery to me. |
bwoodsend
force-pushed
the
pyinstaller-hook
branch
from
252ea91
to
b2d4cef
Compare
bwoodsend
force-pushed
the
pyinstaller-hook
branch
from
b2d4cef
to
a8e21dc
Compare
|
PyInstaller's |
Adding this special hook file tells PyInstaller what files a self contained NumPy application needs to run. A test is included to verify that the hook still finds all necessary files. Closes numpy#17184.
bwoodsend
force-pushed
the
pyinstaller-hook
branch
from
a8e21dc
to
bac9d0e
Compare
|
That's this rebased so as to include #20831. |
|
Thanks @bwoodsend . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this special hook file tells PyInstaller what files a self contained NumPy application needs to run. A test is encluded to verify that the hook still finds all necessary files.
Closes #17184.