Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: use concurrent.futures.ThreadPoolExecutor in distutils instead of multiprocessing.pool.ThreadPool #21027

Merged
merged 1 commit into from Feb 10, 2022

Conversation

GalaxySnail
Copy link
Contributor

Use concurrent.futures.ThreadPoolExecutor in distutils instead of multiprocessing.pool.ThreadPool.

Fix #21026

Use `concurrent.futures.ThreadPoolExecutor` in distutils
instead of `multiprocessing.pool.ThreadPool`.

Fix numpy#21026
@mattip mattip merged commit 06ac508 into numpy:main Feb 10, 2022
@mattip
Copy link
Member

mattip commented Feb 10, 2022

Thanks @GalaxySnail.

@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @GalaxySnail! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

@GalaxySnail
Copy link
Contributor Author

Should this be backported to 1.22.x and 1.21.x? According to scipy/oldest-supported-numpy, 1.21.4 is the oldest version that supports python 3.10. NEP 29 says 1.19+ will be maintained until 2022-06-21, but it seems that only security fixes are acceptable.

@mattip
Copy link
Member

mattip commented Feb 11, 2022

I don't think we ever declared support for android in NumPy, so it is not "critical" to backport but "nice to have". The final decision is up to @charris.

@charris
Copy link
Member

charris commented Feb 11, 2022

I don't have a problem with backporting build fixups, but that would only be for NumPy 1.22, we generally only update the latest release.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Feb 11, 2022
@charris charris added this to the 1.22.3 release milestone Feb 11, 2022
@GalaxySnail
Copy link
Contributor Author

Thanks!

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Mar 2, 2022
@charris charris removed this from the 1.22.3 release milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Failed to build numpy on Android
4 participants