BUG: Fix unpickling an empty ndarray with a non-zero dimension #21067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
changed the title
|
Could probably just use |
|
Thank you @seberg! Learned a lot in the process—I can likely start valgrind now 😂 |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Mar 2, 2022
…y#21067) Changing num to the number of bytes in the input array, PyArray_NBYTES(self). Solves numpy#21009. * Fixing nbyte size in methods.c:memcpy * Adding a test * Re-adding removed newline * Shrinking the test array to save memory
charris
added a commit
that referenced
this pull request
Mar 3, 2022
BUG: Fix unpickling an empty ndarray with a none-zero dimension (#21067)
lithomas1
pushed a commit
to lithomas1/numpy
that referenced
this pull request
Mar 6, 2022
…y#21067) Changing num to the number of bytes in the input array, PyArray_NBYTES(self). Solves numpy#21009. * Fixing nbyte size in methods.c:memcpy * Adding a test * Re-adding removed newline * Shrinking the test array to save memory
charris
changed the title
melissawm
pushed a commit
to melissawm/numpy
that referenced
this pull request
Apr 12, 2022
…y#21067) Changing num to the number of bytes in the input array, PyArray_NBYTES(self). Solves numpy#21009. * Fixing nbyte size in methods.c:memcpy * Adding a test * Re-adding removed newline * Shrinking the test array to save memory
seberg
pushed a commit
to seberg/numpy
that referenced
this pull request
Apr 24, 2022
…y#21067) Changing num to the number of bytes in the input array, PyArray_NBYTES(self). Solves numpy#21009. * Fixing nbyte size in methods.c:memcpy * Adding a test * Re-adding removed newline * Shrinking the test array to save memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
numto the number of bytes in the input array,PyArray_NBYTES(self). Solves #21009.