TYP,MAINT: Explicitly allow sequences of array-likes in np.concatenate
#21102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These all concern known false positives due to known mypy bugs. If one of these tests break, than that would generally be indicative of a upstream bug fix
BvB93
added
03 - Maintenance
09 - Backport-Candidate
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20901, alternative to #20903.
Explicitly allow a sequence of array-like objects in
np.concatenate, rather than just array-likes.Note that this does not fully get rid of all false positives, i.e. heterogeneous tuples of array-likes still aren't accepted due to what appears to be a mypy bug.